Re: [SM-DEVEL] per Identity sent_folder - patch available

[Paul L. <pa...@sq...>]

David Carrel wrote:
> Hi, I'm a long time Squirrelmail user.  Thanks for creating it and
> maintaining it!!
> 
> One thing that has bugged me about squirrelmail for a while is that I
> couldn't set a "Sent Folder" for each identity that is defined.  My other
> mail tools let me do that.  I found the variable_sent_folder plugin and
> this suffices, but it required me to always remember to set the "Sent
> Folder".  Often I am replying to email quickly and I forget.  So I finally
> got off my tush and worked up the code to allow an optional "Sent Folder"
> for each identity.  The changes are quite small.  The folder is configured
> on the Advanced Identities page.  The Default Identity uses the normal
> sent_folder variable so nothing changes for that.  Other Identities
> default to having no "Sent Folder" configured which means that the default
> sent_folder is used.  The per-Identity "Sent Folder"'s works whether the
> identity is auto-selected in a reply or the user selects it via the
> pulldown on the compose page.
> 
> Additionally I made changes to the variable_sent_folder plugin so that it
> auto-updates the "selected" folder in its pulldown when the compose screen
> starts and whever the From Identity is changed.
> 
> My patch is available if anyone wants it.  It only changes two files:
> src/option_identities.php and functions/identity.php
> (There is a separate patch for the variable_sent_folder plugin.)

You should send the patch to the list.  I fail to see why you can't do
it as a plugin, unless the very recent identity hooks changes borked
things up.  You should be able to put an extra form element under each
identity where you select the folder name - shouldn't be very hard
unless, again, those identity hooks have gone missing as of 1.4.5.

> The downside is that this is not implemented as a plugin.  identity.php
> just doesn't have the necessary hooks and it seemed that adding the hooks
> was much less clean than adding my code.  My code changes are quite small
> and IMNSHO having a per-Identity "Sent Folder" seems like something that
> should be a part of the base system.  I might be willing to work on hooks
> if there is interest.  But for now I hope these patches can be of use. 
> I'd sure love to see it get incorporated.
> 
> Dave
> 
> P.S.  I hope this hasn't been discussed too much before.  I looked around
> and couldn't find and references to this topic, but I easily could have
> missed it.