From: Maurice M. <Mau...@in...> - 2004-06-18 13:54:22
|
Hi, > > I think that the alternating color for showing addresses in > > src/addressbook.php should be changed to match the message list's > > alternating color. The code snippet this applies to is: > > You are absolutely right, even more the alternative should not be '' but should be $color[4]. I've fixed this in DEVEL and STABLE brances. I think the same goes for using the addressbook from the message compose screen. There I see the same type of problem. Another problem that I have noticed, but of which the people who are working on it are probably aware, is that in the CVS tree I cannot use the message list buttons "Mark read", "Mark unread" and "Forward". "Delete" works fine, but the other buttons will just get me back to the same page I was before. Some code seems to be moved from "src/move_messages.php" to "functions/mailbox_display.php", so that's probably where things have gone skew. I have been looking into it, but couldn't find the exact problem. I got a bit lost in the following code: case 'attache': $aMsgHeaders = array(); foreach ($aUid as $iUid) { $aMsgHeaders[$iUid] = $aMailbox['MSG_HEADERS'][$iUid]; } if (count($aMsgHeaders)) { $composesession = attachSelectedMessages($imapConnection,$aMsgHeaders); // dirty hack, add info to $aMailbox $aMailbox['FORWARD_SESSION'] = $composesession; } I have added a print_r($_POST), right after the start of the function handleMessageListForm(). If I assign a null value to the line below "dirty hack", the debug print_r will print out the post request (including the attache button and a list of message numbers). If I assign a non-null value (so it doesn't have to be $composesession, but simply "1" will do) the debug print_r will print out an empty array. I don't get this. Since print_r() comes much earlier in the code, I would say the output shouldn't differ for these two cases. Apparently there's some very strange dependancy of which I'm not aware... (how dirty is the hack exactly, BTW? ;-). print_r output with null value assignment for $aMailbox['FORWARD_SESSION']: Array ( [msg] => Array ( [1] => 101 ) [mailbox] => INBOX [startMessage] => 1 [attache] => Doorsturen [targetMailbox] => INBOX ) print_r output with value assignment for $aMailbox['FORWARD_SESSION']: Array ( ) In either case, I got back to the same page and "Forward" wouldn't open a compose screen with the selected messages attached. I hope this is of any use to you. Kind regards, Maurice Makaay |