#39 patch for over quota/move_to_trash fail

closed-fixed
None
7
2014-08-17
2002-12-01
Mike Markley
No

Because SquirrelMail has to copy a message to the trash
folder *before* deleting it, we run into a situation
where a user over quota who has move_to_trash turned on
cannot delete any messages. In fact, even if the
message didn't have to be copied before deletion this
would present a problem depending on how over quota a
user is and how big the deleted message is. One
possible approach would be to disable quotas on each
users' Trash folders, but that's not a very pleasant
solution. Instead, I've grabbed the quota functions out
of Bill Shupp's quota_usage plugin and integrated them
into sqimap_messages_delete(). There is a namespace
collision with the quota_usage plugin because Bill
opted to use sqimap_get_quota() as the name for his
function, which is IMO the most reasonable name for the
one I put in imap_messages.php, but since they work the
same it's a minor fix.

I've attached a unified diff against SquirrelMail 1.2.9.

Discussion

  • Mike Markley
    Mike Markley
    2002-12-01

    Unified diff (against SM 1.2.9) of fix

     
    Attachments
    • priority: 5 --> 7
     
    • status: open --> closed-out-of-date
     
  • Logged In: YES
    user_id=285765

    Thank you for your patch. This problem is solved in our
    current SquirrelMail version by the "Bypass Trash" modifier
    for Delete.

     
    • labels: 310314 -->
    • status: closed-out-of-date --> open-out-of-date
     
  • Tomas Kuliavas
    Tomas Kuliavas
    2006-09-25

    • assigned_to: nobody --> tokul
     
  • Tomas Kuliavas
    Tomas Kuliavas
    2006-09-25

    Logged In: YES
    user_id=225877

    We could also just ignore message copy to trash error and
    tag oversized message as deleted after failed 'copy to
    trash' command.

     
  • Tomas Kuliavas
    Tomas Kuliavas
    2006-09-30

    Logged In: YES
    user_id=225877

    SquirrelMail 1.5.2cvs and 1.4.9cvs ignore message copy
    errors when messages are deleted.

    Interface tries to copy message to trash and then tags it as
    deleted. If we can store message in trash, message is
    stored. If we can't, trash folder is bypassed.

    IMAP QUOTA extension can't be used, because some servers
    (UW) don't support it.

     
  • Tomas Kuliavas
    Tomas Kuliavas
    2006-09-30

    • status: open-out-of-date --> closed-fixed