Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#173 Standards Mode instead of Quirks Mode

closed-fixed
nobody
None
5
2012-01-04
2011-03-24
Ben
No

Squirrel Mail <=1.4.21 renders in "Quirks" Mode. For better standards support (eg CSS2) in modern browsers, it should render in "Standards" mode.

This can be achieved by modifying the DOCTYPE declaration to either:-
* Strict mode (<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">)
* Transitional mode including the URL for the DTD. (<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 ransitional//EN" "http://www.w3.org/TR/html4/loose.dtd">)
* HTML5 standards mode (<!DOCTYPE html>)

Presently the DOCTYPE declaration is Transitional *without* the URL for the DTD.

/functions/page_header.php
29. echo '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">' .

Discussion

  • Thanks for your input. It's tempting to make this change, but changing from quirks to standards mode could have unforeseen consequences for parts of the core or plugins. We try not to make changes in our STABLE branch that will affect current functionality, and this change is huge in that it affects every page SquirrelMail creates. I will solicit opinions on the squirrelmail-devel mailing list today and see what others think.

    I have attached a patch for this issue.

     
  • I'm proposing a new configuration setting that allows the administrator to choose which mode they'd like to render in. Please see the new patch that I've just attached.

     
  • I have altered the patch to allow for quirks, almost standards, or standards mode. I don't know as it makes much sense to allow HTML5, but that could be more easily added to this scheme as well. Please see the newer patch I am attaching today.

     
    • status: open --> closed-fixed
     
  • Patch has been applied