#28 Missing properties for {}-style response (review for STABLE)

closed
nobody
None
5
2002-10-23
2001-12-17
No

Our Exchange server returns properties using {length}
to denote the length of the following string, as in the
example below

("name" {40}

Felmeddelande för att öppna dokument.doc)

This does not seem to be handled by the parser in
mime_get_props in functions/mime.php3. Due to this,
attatchments f.ex. get names like untitled-2.mime-type

The appended patch adds this functionality to
mime_get_props and also reformats the comment according
to the comment at the top of the file. Although I think
this function should be totally rewritten, this patch
aims at having as little impact as possible on the
surrounding code. Ie, with this added it is rather ugly...

(The patch is against the CVS snapshot of 20011214)

Discussion

  • Patch for mime_get_props

     
    Attachments
  • Logged In: YES
    user_id=366298

    I found another place in mime.php where parsing of
    {}-strutures is needed, in mime_get_element. Without this
    the encoding sometimes get an invalid value.

     
  • More complete patch for mime.php

     
    Attachments
  • Bron Gondwana
    Bron Gondwana
    2002-01-15

    • assigned_to: nobody --> brong
     
  • Bron Gondwana
    Bron Gondwana
    2002-01-15

    Logged In: YES
    user_id=9941

    The real solution is to actually write an IMAP
    interoperation layer rather than making each little
    function deal with every degenerate case. I'm looking at
    how hard that change will be to make.

    (haven't read the patch yet, but will download it when I'm
    looking at the rest).

     
    • summary: Missing properties for {}-style response --> Missing properties for {}-style response (review for STABLE)
    • assigned_to: brong --> graf25
     
  • Logged In: YES
    user_id=147248

    I know this is quite ancient... Nevertheless, I committed
    this into 1.3-devel. Slating to be put into 1.2-stable if
    testing shows no problems (so far so good).

     
  • Logged In: YES
    user_id=147248

    Attaching a patch against 1.2-stable for review.

     
  • Patch for this issue against 1.2-stable.

     
    Attachments
  • Jason Munro
    Jason Munro
    2002-06-14

    Logged In: YES
    user_id=442854

    graf25:
    while knocking out the 'review for stable'
    patches this one failed to apply. Since you wrote it, will
    you check this out?

    thanks

    jason
    jason@stdbev.com

     
  • Logged In: YES
    user_id=285765

    Any progress on this one?

     
  • Logged In: YES
    user_id=285765

    Hello,

    Your report was filed against an old version of SquirrelMail. We
    have new releases out which have fixed many issues. Can you
    please test the most recent version - or even better the CVS
    version - and report if this issue still exists? Thanks!

     
    • status: open --> pending
     
    • status: pending --> open
     
  • Logged In: YES
    user_id=366298

    I'm sorry, but I am unable to test this anymore. Due to a
    job change I no longer have access to an MS Exchange server.
    Btw, the Exchange server used at my former job is version
    5.5 if this behaviour differ between versions.

     
    • assigned_to: graf25 --> nobody
    • labels: 102904 -->
     
  • Logged In: YES
    user_id=285765

    I'm labeling this as devel and since this has been
    integrated into devel already, close it.

     
    • status: open --> closed