#2416 [filters] multiple issues in filters plugin

closed-fixed
5
2009-01-04
2007-01-13
Tomas Kuliavas
No

People on irc suggested filing only one report.

1st issue (1.5.2cvs and 1.4.9a). in start_filters() function plugin checks if spam filtering is enabled.
---
foreach($spamfilters as $filterskey=>$value) {
if ($value['enabled'] == 'yes') {
$AllowSpamFilters = true;
break;
}
}
---
Test is not correct. Plugin stores checkbox form input value. If value attribute is not set in checkbox, it is set to 'on' string in Opera 9.10, Firefox 1.5.0.7 and IE6. Setting is boolean. Use SMPREF_ON and SMPREF_OFF constants instead of custom form string.

2nd issue. invalid return codes in spamhaus.org rbl
sbl.spamhaus.org return code is 127.0.0.2. 4,5,6 codes belong to xbl.spamhaus.org. Plugin runs sbl.spamhaus.org query and checks for 127.0.0.6.

See http://www.spamhaus.org/xbl/index.lasso

3nd issue (1.4.x branch only) only one message is tested for spam in stable. Plugin executes sqimap_run_command() and $read contains only first FETCH response.

4th issue (1.4.x branch only)
id is used instead of uid

Plugin always uses id when messages are moved. sqimap_message_copy() and sqimap_message_flag() need UID, if $uid_support is set to true. $uid_support defaults to true. I also recommend collecting all spam ids and executing one command instead of multiple imap commands.

Discussion

<< < 1 2 (Page 2 of 2)
    • status: open --> open-fixed
     
  • The bug you reported has already been fixed, and the fix is committed to the repository. Please update to the latest version in the repository or use a new snapshot. Note that the snapshots might be delayed 24 hours compared to the repository.

    If for some reason your problem still exists, please update this bug report with that information.

    Thank you for your help!

     
    • status: open-fixed --> closed-fixed
     
<< < 1 2 (Page 2 of 2)