#1994 Rfc822Message::processParameter is broken

closed-fixed
Seth Randall
5
2006-01-11
2006-01-01
Evan Buswell
No

This function destroys parameters rather than
processing them. I honestly can't make heads or tails
of where the programmer was going, so for lack of a
better solution I'm now going:

processParameters($aParameters) {
return $aParameters;
...
}

This should be fine for 99% of the mail out there; most
headers which have parameters (x=y) don't use fancy
charset encoding. I applaud the effort to getting RFC
compliant, but clearly the code as it stands is worse
than nothing.

This applies to at least squirrelmail v. 1.4.5

It also would probably fix the (closed?) bug:

[ 806698 ] UTF-8 messages are not decoded when using reply

Evan (evanb@zami.no-ip.org)

Discussion

  • Tomas Kuliavas
    Tomas Kuliavas
    2006-01-01

    Logged In: YES
    user_id=225877

    From 806698 bug report:
    ----
    Fixed in 1.4.4cvs and 1.5.1cvs. lossy_encoding option must
    be set to true, because iso-8859-1 does not cover all
    symbols supported by utf-8 charset.
    ----

    SquirrelMail should read utf-8 encoded emails correctly. If
    lossy_encoding option is enabled, it should convert utf-8
    emails to character set used by selected translation and
    display supported Unicode characters in compose window.
    Option is not enabled by default, because other SquirrelMail
    character sets don't support all utf-8 characters.

    806698 bug is closed because it is fixed. If you think that
    it is not fixed - provide message that is not converted
    correctly when lossy encoding is enabled and utf-8 message
    uses characters supported by selected translation.

     
  • Logged In: YES
    user_id=285765

    Assigning to Seth; since you seem to have constructed most
    of this function, can you handle this?

     
    • assigned_to: nobody --> indiri69
     
  • Logged In: YES
    user_id=620333

    I believe that the bug you reported has been fixed in the CVS version. Please either grab a live CVS version or wait and grab an archive of the CVS from tomorrow or later (just to make sure it has the changes in it).

    If the bug does not exist after you update to the CVS version, please close this bug report.

     
    • status: open --> closed-fixed
     
  • Logged In: NO

    need to change password

     
  • Evan Buswell
    Evan Buswell
    2006-01-27

    Logged In: YES
    user_id=805846

    confirmed. This works now.

    --Evan

     
  • Logged In: NO

    i cannot start my sqrl an i don't know why.Please someone
    for help me.