#1573 Message with MDN causes different behaviour when reading

closed-fixed
5
2005-05-27
2004-04-03
Martin Mueller
No

When reading a message via shift-left-click the message
is shown in a new browser window. The content of the
main browser window (i.e. list of e-mails in the Inbox) is
not changed.

If the message contains a MDN this behaviour is
different. In that case the main browser window content
changes and displays the e-mail (as does the new
browser window).

Issue can be reproduced with SM 1.4.2 and IE 6

Regards,

Martin

Discussion

  • Logged In: YES
    user_id=620333

    I have just taken a look at the code, and I cannot really
    see a refresh that'd cause the parent frame to reload. I'll
    keep searching.

     
  • Logged In: YES
    user_id=620333

    I just worked out the cause of this, well I actually spotted
    it a while ago, but got sidetracked by some other projects.
    The cause is you are using Javascript. The javascript
    calls a window.open, with the second argument being the
    frame name "right" which is the name of the frame which the
    mail appears in. This is why you are seeing the behaviour
    you are.

    I have attached a patch, if you could test it, and see if it
    resolve your issue. I have tested this against Firefox 1.0,
    and IE 6 SP2. To apply the patch, copy it to your server,
    change directory so you have the SquirrelMail directory as
    your active path, and type:

    patch -p0 < /path/to/page_header_mdn.diff

    This patch was done against 1.4.4.

    As a side note, it is strongly recommended that you upgrade
    to the latest release due to several security issues
    resolved in 1.4.3a, and 1.4.4.

     
    • assigned_to: nobody --> jangliss
     
  • Logged In: YES
    user_id=285765

    The patch looks good to me. I propose to apply it to cvs so
    it can get some more testing.

     
  • Logged In: YES
    user_id=285765

    Jon,
    Shall we apply this patch soon so we can get it into the
    next release?

     
  • Logged In: YES
    user_id=620333

    Go ahead, I think this patch has been in devel for a bit if
    I remember correctly.

     
    • assigned_to: jangliss --> kink
     
    • status: open --> closed-fixed