Re: [Squirrel-sql-develop] Multiple windows patch issues to resolve

[Colin B. <co...@in...>]

Hi Jason,

On Tue, Aug 17, 2004 at 07:58:24AM +0930, Height, Jason wrote:

> I notice that there are a number of comments with //JASON in the code
> that you have questions over. Yep I actually read MOST of the commit
> logs ;-)

I'm glad somebody does.

I hadn't intended to appply your patch back into CVS until after beta7
but the two streams were starting to move apart again so I decided to
make beta7 the "bigger than Ben Hur" release.

> Let me know when it is safe to start working on them so that I can
> supply you a patch where required. Or if you have some ideas on how to
> address some comments then fire away ahead.

The JASON: tag is actually a TODO tag just for this patch, but many of
the notes will end up being questions for you. Give me a few more days
on it and I'll have a lot of questions for you, trust me on this :-)

> I haven't tried to compile the app yet, just refreshing my CVS
> repository for a clean start!

It doesn't compile at the moment, but it will run. The code that doesn't
comile is actually not executed, its just sitting there waiting for me
to reapply it back in to your new code

Thanks for the patch, and thanks for your patience waiting for me to
apply it.

-- 
Colin Bell
http://www.squirrelsql.org