#818 incompetent shell scripting

3.0.3
closed-fixed
Rob Manning
5
2014-07-14
2010-01-17
Blaine Simpson
No

squirrel-sql.sh doesn't pass basic Bash syntax checking with mainstream Bash interpreter:

beyla$ /bin/sh -n /local/SQ*/*sh
/local/SQuirreL-3.0.2/squirrel-sql.sh: line 63: unexpected EOF while looking for matching ``'
/local/SQuirreL-3.0.2/squirrel-sql.sh: line 92: syntax error: unexpected end offile
beyla$

The author doesn't seem to understand how to use a case statement, that semi-colons are superfluous with newlines in shell scripts; that simple variable assignments should just set strings and test for that instead of actually executing the true/false built-ins for every logical expression test,...

Discussion

  • Rob Manning
    Rob Manning
    2010-02-07

    Fixed in CVS. The change will be available in the next snapshot.

     
  • Rob Manning
    Rob Manning
    2010-02-07

    • milestone: --> 3.0.3
    • status: open --> closed-fixed