Recent changes to patches

#108 Columns with keyword names are problematic for some queries

Oleg Broytman — Sun, 28 Apr 2013 10:43:49 -0000

status: open-invalid --> closed-rejected
Group: --> Unstable_(example)

#110 add test for bug #274 Cannot insert explicit value for identity column

Oleg Broytman — Tue, 05 Feb 2013 20:26:47 -0000

status: open --> closed-accepted
assigned_to: Oleg Broytman
milestone: -->

#111 fix #274 Cannot insert explicit value for identity column

Oleg Broytman — Tue, 05 Feb 2013 20:26:07 -0000

status: open --> closed-accepted
assigned_to: Oleg Broytman
milestone: -->

fix #274 Cannot insert explicit value for identity column

Andrew Ziem — Sun, 03 Feb 2013 22:49:22 -0000

Tested with Python 2.7.3 32-bit, Windows 7, sqlobject 1.3.2, adodbapi 2.4.2.2, SQL Server 2008. Fixes test_identity and a few other tests

fix #274 Cannot insert explicit value for identity column

Andrew Ziem — Sun, 03 Feb 2013 22:49:22 -0000

Ticket 111 has been modified: fix #274 Cannot insert explicit value for identity column
Edited By: Oleg Broytman (phd)
Status updated: u'open' => u'closed-accepted'
Owner updated: None => u'phd'

add test for bug #274 Cannot insert explicit value for identity column

Andrew Ziem — Sun, 03 Feb 2013 22:01:56 -0000

attached

add test for bug #274 Cannot insert explicit value for identity column

Andrew Ziem — Sun, 03 Feb 2013 22:01:56 -0000

Ticket 110 has been modified: add test for bug #274 Cannot insert explicit value for identity column
Edited By: Oleg Broytman (phd)
Status updated: u'open' => u'closed-accepted'
Owner updated: None => u'phd'

#109 Use "insert ... returning id" with postgres

Oleg Broytman — Sat, 19 Jan 2013 18:33:49 -0000

status: open --> closed-accepted
milestone: -->

#109 Use "insert ... returning id" with postgres

Oleg Broytman — Sat, 19 Jan 2013 18:33:20 -0000

I have to work on the patch. There were two problems. First, it was created against branch 1.2 and I have to modify it to apply to the trunk. Second, it creates a possibility for an INSERT without columns in case like

1 2	class Test(SQLObject): pass

SQLObject has never had a need to handle such a case — at least the id column was always there. With your patch SQLObject has to generate query "INSERT INTO table DEFAULT VALUES" instead of "INSERT INTO table () VALUES ()".

Now everything works. Applied and committed in the revision 4574 in the trunk. Will be in the next release. Thank you!

Use "insert ... returning id" with postgres

Ken Lalonde — Fri, 18 Jan 2013 18:39:03 -0000

When inserting records with driver postgres, it's faster to use the single statement "INSERT ... RETURNING id",
rather than 2 statements -- one to get the current sequence value (and increment it), and another to do the insert.
Patch is against SQLObject-1.2.4/sqlobject/postgres/pgconnection.py.