#77 sqlbuilder.Select with JOINs

closed-accepted
Oleg Broytman
None
5
2006-11-10
2006-11-07
Luke Opperman
No

Attacking the "dbconnection.queryForSelect /
sresults.SelectResults don't use sqlbuilder.Select"
issue a piece at a time, and I needed this for a
simpler purpose:

sqlbuilder.Select does not know how to handle
sqlbuilder.SQLJoin instances. This diff adds the logic
from dbconnection._fixTablesForJoins and
dbconnection._addJoins to Select, taking a "join"
parameter as SQLObject.select/sresults.SelectResults does.

Trivial test added to the other tests of
sqlbuilder.Select, not a realistic use of a SQLJoin
however.

Discussion

  • Luke Opperman
    Luke Opperman
    2006-11-07

     
    Attachments
  • Oleg Broytman
    Oleg Broytman
    2006-11-10

    • assigned_to: nobody --> phd
    • status: open --> closed-accepted
     
  • Oleg Broytman
    Oleg Broytman
    2006-11-10

    Logged In: YES
    user_id=4799

    Very nice! Applied and committed in the revisions 2069-2071.
    Thank you!