#60 Fix for bug 1458595 (destroySelf in Transaction = deadlock)

closed-invalid
Oleg Broytman
None
5
2006-04-06
2006-03-26
Cody Pisto
No

This patch fixes bug 1458595, in which actions that
resulted in Transaction._SO_delete being called
resulted in an additional database connection being
opened, causing a deadlock while multiple connections
await on eachothers commit.

This patch is against svn trunk,
r1668. (dbconnection.py)

Discussion

1 2 > >> (Page 1 of 2)
  • Cody Pisto
    Cody Pisto
    2006-03-26

    Fix

     
    Attachments
  • Oleg Broytman
    Oleg Broytman
    2006-03-27

    Logged In: YES
    user_id=4799

    Your patch duplicates the query from DBAPI._SO_delete() to
    Transaction._SO_delete(). Would you mind to refactor your
    patch - split DBAPI._SO_delete() into two methods - one to
    generate a query string, and another to execute the query;
    then use the first method to generate a query in the
    Transaction._SO_delete()?

     
  • Cody Pisto
    Cody Pisto
    2006-03-27

    Logged In: YES
    user_id=118227

    Sure, ill refactor-
    Revised patch will follow this evening.

     
  • Oleg Broytman
    Oleg Broytman
    2006-03-28

    Logged In: YES
    user_id=4799

    Problems? :)

     
  • Oleg Broytman
    Oleg Broytman
    2006-03-28

    • assigned_to: nobody --> phd
    • status: open --> open-invalid
     
  • Cody Pisto
    Cody Pisto
    2006-03-28

    Logged In: YES
    user_id=118227

    sorry, lost track of time, patch will follow today ;)

     
  • Luke Opperman
    Luke Opperman
    2006-04-04

    Logged In: YES
    user_id=1393478

    See patch #1464379

     
  • Oleg Broytman
    Oleg Broytman
    2006-04-05

    Logged In: YES
    user_id=4799

    Cody, any opinion on the alternate fix?

     
  • Cody Pisto
    Cody Pisto
    2006-04-05

    Logged In: YES
    user_id=118227

    Luke's fix looks good, solves the problem my patch
    addresses, and resolves the duplication of code the patch
    incurred.

     
  • Oleg Broytman
    Oleg Broytman
    2006-04-06

    Logged In: YES
    user_id=4799

    Ok, I'll apply and test it...

     
1 2 > >> (Page 1 of 2)