Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#46 Events RowCreateSignal not really useful, added post-create

closed-accepted
nobody
None
5
2006-02-11
2006-02-03
Rick Richardson
No

The RoWCreateSignal suffers from two drawbacks based on
the fact that it fires before a row is created.

First, it can't give a reference to the created row
(which is what i would picture a large percentage of
users would want it for)

Secondly, it fires whether the row was successfully
created or not.

In the case of the auditing system that i'm writing. I
desperately need these two features. So I added a
RowCreatedSignal and then added the code to invoke it
in the _SO_finishCreate function and it passes the
created ID and the class to the callback.

I've tested it. seems to work alright. Attached is the
patch if you wish to use it.

Rick

Discussion

  • svn diff for events.py and main.py

     
    Attachments
  • Ian Bicking
    Ian Bicking
    2006-02-11

    • status: open --> closed-accepted
     
  • Ian Bicking
    Ian Bicking
    2006-02-11

    Logged In: YES
    user_id=210337

    Applied in r1596.