#5 Reorganized code and handle of white scanlines issue.

open-fixed
None
5
2011-02-20
2009-10-16
Leonardo Hamada
No

Detailed description on the problem:
-----------------------------------------

A printable page is divided in a number of horizontal bands that is 128 pixels height in 600dpi or 64 pixels height at 300dpi mode.

There was a case error in the encoder when the band begins with blank scan-lines, this made the encoded band as if there was exactly 129 pixels in height (or 65 pixels at 300 dpi).

When this 129th scan-line was decoded on the printer, this scan-line appeared at some location on the page near the affected band, in studied case of the dump file sent, just over it.

These mysterious marks were in fact the last scan-line of the band but it was offset by one scan-line down out of the band area and the printer put it on other location.

Also, I've consolidated some code in the affected function in the same patch, this will modify the algo0x0d.cpp
and lgo0x0d.h fles and update it.

Thanks a lot,

Leonardo Hamada

Discussion

  • Till Kamppeter
    Till Kamppeter
    2010-07-29

    Fixed in SVN revision 268. Thanks for the patch.

     
  • Till Kamppeter
    Till Kamppeter
    2010-07-29

    • status: open --> closed-fixed
     
  • Thank-you, Till.

     
    • status: closed-fixed --> open-fixed
     
  • Till Kamppeter
    Till Kamppeter
    2010-07-29

    • assigned_to: nobody --> tillkamppeter
    • status: open-fixed --> closed-fixed
     
    • status: closed-fixed --> open-fixed
     
  • This patch changes the files include/algo0x0d.h and src/algo0x0d.cpp, I think it shouldn't affect this printer model in particular as it uses another encoder.

    Hope it helps,

    Leonardo