#79 Install DRV files instead of PPD files

v2.0
open
ppd (20)
5
2014-07-21
2011-12-01
Jiri Popelka
No

Hi.

What do you think about installing (could be optional) DRV files instead of the PPD files ?
The only drawback I can think of is that as it works now when using DISABLE_JBIG=1 the PPDs for printers that need JBIG1 support are not installed. This is not possible with DRVs as we can't rip out the JBIG1 printers from DRVs.
On the other side as JBIG1 will be free of known patents in all countries from 2012-04-04 onwards (http://www.cl.cam.ac.uk/~mgk25/jbigkit/patents/), the DISABLE_JBIG option won't be much useful anyway.

I'm attaching patch that enables to assemble and install only DRV files.
There's new DRV_ONLY option that enables this behavior (it's disabled by default)
and CUPSDRV variable that specifies where to install these DRVs (default is `cups-config --datadir`/drv).

'make drv' in ppd directory assembles *.drv from *.drv.in (assuming that you rename the *.drv files in repository to *.drv.in because they are actually only a templates).
Passing 'DRV_ONLY=1' to 'make install' then installs only these DRVs instead of PPDs.

Jiri Popelka
(the initial idea was Tim Waugh's)

Discussion

  • Jiri Popelka
    Jiri Popelka
    2011-12-01

    Patch

     
    Attachments
  • Jiri Popelka
    Jiri Popelka
    2011-12-01

    • assigned_to: ap2c --> tillkamppeter
     
  • Jiri Popelka
    Jiri Popelka
    2011-12-01

    Just a note that this solution saves even more space than compressing the PPD files with pyppd.

     
  • Till Kamppeter
    Till Kamppeter
    2012-02-29

    Thank you for the patch.

    When I try to apply the patch to the current SVN snapshot I get:

    till@till:~/printing/splix/splix$ patch -p1 < ../splix-drv.patch
    patching file INSTALL
    patching file module.mk
    patching file ppd/compile.sh
    patching file ppd/Makefile
    patching file rules.mk
    patch unexpectedly ends in middle of line
    patch: **** malformed patch at line 210:

    till@till:~/printing/splix/splix$

    Are you sure whether it got completely uploaded?

     
  • Till Kamppeter
    Till Kamppeter
    2012-02-29

    Thank you very much for the patch. After adding a final newline to the patch it applies correctly.

    Fixed in SVN revision 306.

     
  • Till Kamppeter
    Till Kamppeter
    2012-02-29

    • status: open --> closed-fixed
     
  • Jiri Popelka
    Jiri Popelka
    2012-04-19

    Hi Till,

    you still need to rename all *.drv files in ppd directory to *.drv.in (otherwise 'make ppd' or 'make drv' fails).
    These files are actually only a templates, final drv files are generated by ppd/compile.sh.
    I should have emphasized this more.

    BTW: it's great to see that you merged all my suggestions. Thanks!

     
  • Jiri Popelka
    Jiri Popelka
    2012-04-19

    • status: closed-fixed --> open-fixed
     
  • Jiri Popelka
    Jiri Popelka
    2012-09-24

    Changing the Resolution from Fixed to None per my previous comment.

     
  • Jiri Popelka
    Jiri Popelka
    2012-09-24

    • status: open-fixed --> open
     
  • Till Kamppeter
    Till Kamppeter
    2013-08-26

    Jiri, the .drv.in problem is fixed now on SVN.