Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#8 Redraw Sparklines deletes All Shapes

closed-accepted
None
5
2009-03-22
2009-03-20
Andreas F
No

Tested with Standalone v3.3 and Installer 3.3 Beta 5

Actual:
When using the "Redraw Sparklines" Function, the Sparklines are deleted and redrawn. All other Shapes are deleted, too.

Expected:
Only the Sparkliens are deleted and redrawn, other Shapes are not modified.

Proposed Solution:
In
Module SparklinesSheetActions
Sub RedrawSparklinesOnSheet()

-> Replace the Code that does Shape-Deletion with a call to the already defined and working DeleteSparklinesOnSheet().

i.e.
Replace
For Each shp In ActiveSheet.Shapes
Application.Wait DateAdd("s", 0.00001, Now)
If Left(4, "Sprk") = strMatch Then shp.Delete
Next shp

with
Call DeleteSparklinesOnSheet

and some variables like
strLen = Len(ActiveSheet.Name) + 5
might be removed from that sub, too(never used afaik).

Fixed Version of the SparklinesSheetActions (3.3 Beta 5) appended.

Discussion

  • Andreas F
    Andreas F
    2009-03-20

    fixed sub

     
    Attachments
  • Andreas F
    Andreas F
    2009-03-20

    diff original / fixed file

     
    Attachments
  • Andreas F
    Andreas F
    2009-03-20

    File Added: diff.txt

     
  • Thx for this... problem identified & solved !!
    I include it in next release.
    regards

     
    • assigned_to: nobody --> frimlinger
    • status: open --> closed-accepted