#87 Docs: sox.1: typo: `kbs' -> `kbps'

closed-fixed
nobody
None
1
2011-12-26
2011-12-24
Michael Witten
No

In the man page `sox.1', the term that is meant to be used is `kbps' rather than `kbs'.

Discussion

  • Michael Witten
    Michael Witten
    2011-12-24

    • priority: 5 --> 1
     
  • Ulrich Klauer
    Ulrich Klauer
    2011-12-26

    • status: open --> closed-fixed
     
  • Ulrich Klauer
    Ulrich Klauer
    2011-12-26

    Thanks! This is in the repository now.

     
  • Michael Witten
    Michael Witten
    2011-12-28

    Ulrich, I'm glad that the patch made it through.

    However, one of the virtues of `git' is that a patch (no matter how small) can be properly attributed to the exact author who made the contribution.

    In the future, please make sure not to discard such authorship information (including provided authorship dates). This is why I explicitly wrote "Apply with `git am'".

     
  • Ulrich Klauer
    Ulrich Klauer
    2011-12-28

    There's also a case for not unnecessarily cluttering the history, which is why git also has rebase, commit --amend etc. This is a one-character spelling fix in a documentation file we're speaking about, and as you've probably seen I named you in the commit message. In my opinion, that should be enough.

     
  • Michael Witten
    Michael Witten
    2011-12-28

    Rebasing and amending are mainly meant for private organization of a patch series before official publication. Also, a cluttered history is one in which the line of development is not clear, which I do not think could be a characteristic caused by my patch if applied alone. Furthermore, delta compression makes even small commits worthwhile.

    You are throwing away information, and that makes for a cluttered history. With my patch alone, it is very clear what was changed, by whom, and at what point in time. This is now not so clear.

    Consequently, I do not think your rationale is correct.