From: Sebastian T. <seb...@tr...> - 2012-09-17 16:30:47
|
> On Sept. 17, 2012, 12:41 p.m., Sebastian Trueg wrote: > > soprano/node.cpp, line 427 > > <http://git.reviewboard.kde.org/r/106471/diff/1/?file=85714#file85714line427> > > > > Does not look thread-safe. Is it? > > Vishesh Handa wrote: > You're right. It's not thread safe [1]. I think putting a mutex in the createEscapeHash code should fix it. What do you think? > > [1] http://blogs.msdn.com/b/oldnewthing/archive/2004/03/08/85901.aspx I am not sure. That would be a static mutex which I think is bad. Better ask an expert like Thiago or David. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106471/#review19064 ----------------------------------------------------------- On Sept. 17, 2012, 9:50 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106471/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 9:50 a.m.) > > > Review request for Nepomuk, Soprano and Sebastian Trueg. > > > Description > ------- > > Optimize the N3 conversion by escaping all the necessary characters in > one go, and by caching the QString version of the data type. > > They aren't that many data types, so this shouldn't take up too much > space. > > > Diffs > ----- > > soprano/node.cpp 8ebbe0e > > Diff: http://git.reviewboard.kde.org/r/106471/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > > |