This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110897/

This review has been submitted with commit 15748cd9e64c351e0bebcc8907d5a078cd0c4f88 by Simeon Bird to branch 2.9.

- Commit


On June 11th, 2013, 10:43 p.m. UTC, Simeon Bird wrote:

Review request for Soprano and Vishesh Handa.
By Simeon Bird.

Updated June 11, 2013, 10:43 p.m.

Description

    Soprano::Error::ErrorCache stores a QHash <QThread*, Error>
    giving the last error in each thread.
    
    Change the implementation so clearError() calls remove(), instead
    of setting the error to a default value. This prevents the hash
    growing endlessly. It is still possible for error values to leak,
    but only when someone forgets to call clearError() before a thread
     finishes (and only when an actual error occurs).
    
    BUG:320123
    REVIEW: 110897

Testing

Compiled, ran
Bugs: 269442, 320123

Diffs

  • soprano/error.cpp (bff34dd)

View Diff