This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106467/

On February 8th, 2013, 6:33 p.m. UTC, Albert Astals Cid wrote:

What's the status of this? Should it be commited or not? If not maybe we should discarded to get a clearer queue in reviewboard?
The patch seems to be slightly buggy and often skips one character. It needs to be tested more, and some proper benchmarks need to be performed.

- Vishesh


On September 17th, 2012, 9:37 a.m. UTC, Vishesh Handa wrote:

Review request for Nepomuk, Soprano and Sebastian Trueg.
By Vishesh Handa.

Updated Sept. 17, 2012, 9:37 a.m.

Description

    Only use 1 SQLFetchData command in most of the cases.
    
    Callgrind stats show that 67.5% of the time in this function is spent in
    the first SQLFetchData, and an additional 27% in the second SQLGetData.
    We can avoid some of this extra cost, by only calling the function
    once.

I can change the size of the default buffer if required.

Diffs

  • backends/virtuoso/odbcqueryresult.cpp (a4f2387)

View Diff