#85 Lite.pm: Wrongly commented return in call() method?..

0.65
closed-rejected
Martin Kutter
Misc/Other (17)
5
2007-10-09
2005-07-12
dear_angel
No

===>>>=== Lite.pm v0.64_*
sub call {
SOAP2::Trace::trace('()');
my $self = shift;
# Why is this here? Can't call be null? Indicating that
there are no input arguments?
#return $self->{_call} unless @_;
===<<<===

I didn't investigate this problem deeply, but with this
commented return() we have no chance to check faults
on client side with $soap->call->fault (faultstring), coz it
immediately call webservice method again with empty
<body/>...

Please, check it.

Discussion

  • Martin Kutter
    Martin Kutter
    2007-10-09

    Logged In: YES
    user_id=884175
    Originator: NO

    This way of checking errors does not work any more, as the result is not remembered by SOAP::Lite, but just returned.

    Do something like

    my $som = $soap->call('method', %params);
    if ($som->fault()) {
    # fault handling
    }

    to check for faults.

     
  • Martin Kutter
    Martin Kutter
    2007-10-09

    • assigned_to: byrnereese --> kutterma
    • status: open --> closed-rejected
     
  • Martin Kutter
    Martin Kutter
    2007-10-09

    Logged In: YES
    user_id=884175
    Originator: NO

    This way of checking errors does not work any more, as the result is not remembered by SOAP::Lite, but just returned.

    Do something like

    my $som = $soap->call('method', %params);
    if ($som->fault()) {
    # fault handling
    }

    to check for faults.