Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#124 encode_data called incorrectly in envelope

0.65
closed-fixed
Martin Kutter
Encoding (11)
7
2007-10-05
2007-04-13
Anonymous
No

At line 1502:

$body->set_value(SOAP::Utils::encode_data($parameters ? \$parameters : ()))
if $body;

encode_data expects something to be encoded, not a SOAP::Data hash. So nothing gets encoded.

Here's a fix, based on the 0.69 version:

*** Lite.pm.orig 2007-04-13 13:31:11.000000000 -0700
--- Lite.pm 2007-04-13 13:32:35.000000000 -0700
***************
*** 1461,1467 ****

# Find all the SOAP Body elements
} else {
! push(@parameters, $_);
}
}
my $header = @header ? SOAP::Data->set_value(@header) : undef;
--- 1461,1467 ----

# Find all the SOAP Body elements
} else {
! push (@parameters, SOAP::Utils::encode_data($_));
}
}
my $header = @header ? SOAP::Data->set_value(@header) : undef;
***************
*** 1499,1506 ****

}
# This is breaking a unit test right now...
! $body->set_value(SOAP::Utils::encode_data($parameters ? \$parameters : ()))
! if $body;
} elsif ($type eq 'fault') {
SOAP::Trace::fault(@parameters);
$body = SOAP::Data
--- 1499,1505 ----

}
# This is breaking a unit test right now...
! $body->set_value($parameters ? \$parameters : ()) if $body;
} elsif ($type eq 'fault') {
SOAP::Trace::fault(@parameters);
$body = SOAP::Data

Discussion

  • dclaar
    dclaar
    2007-04-13

    Logged In: YES
    user_id=1100591
    Originator: NO

    Sorry for not logging in to submit the bug. I thought it would ask for my credentials, not submit as nobody...
    ==Doug Claar

     
  • Martin Kutter
    Martin Kutter
    2007-10-01

    • priority: 5 --> 7
    • assigned_to: byrnereese --> nobody
    • status: open --> open-accepted
     
  • Martin Kutter
    Martin Kutter
    2007-10-01

    Logged In: YES
    user_id=884175
    Originator: NO

    As there's a patch included, this one should make it soon :)

     
  • Martin Kutter
    Martin Kutter
    2007-10-05

    • assigned_to: nobody --> kutterma
    • status: open-accepted --> closed-fixed
     
  • Martin Kutter
    Martin Kutter
    2007-10-05

    Logged In: YES
    user_id=884175
    Originator: NO

    Fixed in CVS. Will be in next release.