#80 using curl command line escapeshellcmd will cause bug

None
closed-fixed
Gene Wood
None
5
2015-05-31
2012-04-15
jessekii
No

escapeshellcmd will change '?' to '\?' , and will cause 404 not found bug !

so I changed the code:
Line 1012

exec($this->curl_path." -k -D \"$headerfile\"".$cmdline_params." \"".escapeshellcmd($URI)."\"",$results,$return);

to

$safe_url = str_replace(array(' ', '"'), array('%20', '%22'), $URI);
exec($this->curl_path." -k -D \"$headerfile\"".$cmdline_params." \"".$safe_url."\"",$results,$return);

Discussion

  • Gene Wood
    Gene Wood
    2015-05-31

    Thanks for the bug report. Snoopy 2.0.0 no longer uses curl an instead uses openssl so all curl issues are now resolved.

    You can get the new version of Snoopy 2.0.0 here

     
  • Gene Wood
    Gene Wood
    2015-05-31

    • status: open --> closed-fixed
    • assigned_to: Gene Wood
    • Group: -->