#26 Stay on top problems (VideoPreview, FindSubtitles windows)

closed-accepted
nobody
None
5
2009-02-22
2009-02-21
No

Hello,

This patch fixes a problem with VideoPreview and childs windows when "Stay on top" has enabled. In current release these windows are covered by the main window always on Windows and on Linux with some windows managers, because them are treated as independent windows (indeed only using kwin I can see the "VideoPreview" config cialog not covered).

Further, as "VideoPreview" config dialog window is modal, users lose interface control when the dialog is totally covered by the main window.

Discussion

  • Patch #2 fixes the problem related to "stay on top" in FindSubtitles Dialog.

     
  • I think giving the videopreview and findsubtitles windows a parent had the problem (on Windows) that then those windows were always on top of the main window, which I find annoying.

    > Further, as "VideoPreview" config dialog window is modal, users lose
    > interface control when the dialog is totally covered by the main window.

    I think this problem may be fixed in svn r2795 (not sure because here, using the kde, I couldn't reproduce the problem).

     
  • Well... r2795 fixes only video preview config dialog (and the modal related bug) but I think still is a good idea to fix error notification, progress and video preview windows too. They all are temporary windows, it's a likely supposition that users want them visible, and it's available the minimize button to hide the video preview window. This method should be preferable then disabling "stay on top" or resizing or minimizing SMPlayer main window. I can agree about LogWindow, instead.

    Maybe it's better I send next patches in devel mailing-list, so we get rid of problems as "open", "close", "fixed", "semi-fixed", "accepted", etc... I don't know...

     
  • I guess you're right. I've just commited your 2 patches.

     
    • status: open --> closed-accepted