#19 Workaround for MPlayer bug #1321

closed-accepted
nobody
None
5
2009-01-25
2008-11-19
No

Hi,

This patch is a workaround for the MPlayer bug #1321: "MPlayer stalled when option -aid is used with ASF format" (http://bugzilla.mplayerhq.hu/show_bug.cgi?id=1321).

To reproduce the bug in SMPlayer:

1. Open URL: mms://212.162.68.102/prodtvr1
2. Press 'Stop', press 'Play'.

Discussion

  •  
    Attachments
  • Ping. I think that solving this problem is important. What about apply this behaviour for -vid too?

     
  • The url you provided (mms://212.162.68.102/prodtvr1) doesn't work for me, so I can't test the problem.

    First, I think the bug should actually be fixed in mplayer.

    Second, I think I don't understand well your patch. At that moment (function startMplayer) mdat may not be initialized yet, so mdat.audios.numItems() may not return the actual number of audio tracks available.

    Third, what happens if the stream contains more than one audio track? I think in that case the workaround won't fix anything.

     
  • > The url you provided (mms://212.162.68.102/prodtvr1) doesn't work for me,
    > so I can't test the problem.

    Yes, don't work anymore. You can try with: mms://212.162.68.231/EDU2

    > First, I think the bug should actually be fixed in mplayer.

    I agree. Anyway the bug affects more SMPlayer then MPlayer, because currently SMplayer puts -aid and -vid parameters even when this isn't necessary..

    > Second, I think I don't understand well your patch. At that moment
    > (function startMplayer) mdat may not be initialized yet, so
    > mdat.audios.numItems() may not return the actual number of audio tracks
    > available.

    It returns 0 and mdat.audios.numItems() != 1 permits to select stream correctly for files with recorded setting (mset.current_audio_id != MediaSettings::NoneSelected). Of course you may prefer a different way.

    > Third, what happens if the stream contains more than one audio track? I
    > think in that case the workaround won't fix anything.

    Yes, it won't fix anything.

     
    • status: open --> closed-accepted
     
  • Ok, added in svn r2715.