#644 preferred audio/subtitles do not work with regular expressions

version_14.*
open
nobody
5
2015-01-06
2014-08-04
Mikhail
No

Regular expressions for preferred_audio/subtitles do not work in SMplayer as of this moment.
I'm using Qt4 version 14.3.0 (svn rev 36370)

Following is found in logs:
[01:49:01:185] Tracks::findLang: 'eng|us'
[01:49:01:185] Tracks::findLang: lang #0 'rus'
[01:49:01:185] Tracks::findLang: found preferred lang!

full log for smplayer session:
http://paste.kde.org/ph9szeio0

I've found a workaround for this:
(in Track::findLang())
//QRegExp rx(expr) doesn't work as expected: any input is considered valid for expr
QRegExp rx = QRegExp( expr.toUtf8().data()); works as expected

This was verified w/ following code (only inside findLang):
QRegExp test = QRegExp(expr);

if(test.indexIn("test")){
    qDebug("findLang: \"test\" is valid for %s", expr.toUtf8().data());
}

resulting in:
Debug: findLang: "test" is valid for eng|en

This is NOT Qt bug, as QRegExp works as expected in test project, both for char-sequence & QString.
Unfortunately, I can't find what should be blamed for this inside of SMplayer.

P.s.
Thanks for wonderful media app!

1 Attachments

Discussion

  • Mikhail
    Mikhail
    2014-08-04

    'eng|us'
    is valid regexp for
    'rus'
    My mistake. Just ignore this, please.