#601 Add mpv to the players list / manually add path

smtube
closed-fixed
nobody
None
5
2013-12-06
2013-12-03
Götz
No

Hi, would you consider adding the mplayer/mplayer2 fork, mpv, to the players list? Or an option to add a path manually?

Thanks

--- src/players.cpp 2013-12-03 12:54:18
+++ src/players.cpp 2013-12-03 13:03:31
@@ -50,6 +50,8 @@
 Players::Players() {
    list.push_back( Player("SMPlayer", "smplayer", true) );
    list.push_back( Player("MPlayer", "mplayer", false, "-title ") );
+   list.push_back( Player("mpv", "mpv", true) );
    list.push_back( Player("VLC", "vlc", false, "--meta-title=") );
    list.push_back( Player("Dragon Player", "dragon", false) );
    list.push_back( Player("Totem", "totem", false) );

Discussion

  • Done in svn r5932.

     
    • status: open --> closed-fixed
     
  • Götz
    Götz
    2013-12-05

    Thanks!

     
  • Götz
    Götz
    2013-12-06

    Hi,

    list.push_back( Player("mpv", "mpv", false, "-title ") );
    

    is not the best option, as the title won't be displayed on the OSD (a long URL will be displayed).

    When directPlay is true, the title is correctly displayed (and the fourth parameter is not needed).

    list.push_back( Player("mpv", "mpv", true) );
    

    and

    list.push_back( Player("mpv", "mpv", true, "--title=") );
    

    work fine.

    Also, using the new syntax is recommended, as the old one from mplayer may be removed sometime in the future. https://github.com/mpv-player/mpv/blob/master/DOCS/man/en/changes.rst#command-line-switches
    But in the manual page of mpv, there is a warning about using the --title= option, as it may cause significant CPU usage, depending on the properties used and the window manager; so not sure if useful.

    Greetings