Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#4 do_smooth_draw_shadow isn't crashproof

open
nobody
None
5
2010-08-28
2010-08-28
Connor Behan
No

The "trough" case in the do_smooth_draw_shadow function tries to get attirubtes of the variable "part" without making sure part is non-NULL. In fact it is NOT guaranteed to be non-NULL in this function and crashes the new version of xfce4-taskmanager.

Discussion

  • Connor Behan
    Connor Behan
    2010-08-28

    Fix but possibly not a very good one

     
    Attachments
  • Connor Behan
    Connor Behan
    2010-09-04

    You did this in another place too

     
    Attachments