smolder-devel

[smolder-devel] question about hostnames and ports in RSS feed

[Andrew M. <and...@li...>]

Hi Michael and gang -

I recently installed smolder on a non-standard port (8000 instead of
80), and found that I had to make a few changes to
lib/Smolder/Control/Public/Projects.pm to make the RSS feed work for
me. I'm wondering if this is because of a configuration problem on my
side or because I'm not running it on a standard port.

Anyway, here's the diff. It's small enough that you can probably copy
it by eye it into the repository, but let me know if you'd rather I
diff this against svn or something else.

Thanks,
-Andy



diff -ur src/smolder-1.23-src/lib/Smolder/Control/Public/Projects.pm
smolder/lib/Smolder/Control/Public/Projects.pm
--- src/smolder-1.23-src/lib/Smolder/Control/Public/Projects.pm	2008-07-05
14:54:31.000000000 -0500
+++ smolder/lib/Smolder/Control/Public/Projects.pm	2008-08-01
15:52:55.000000000 -0500
@@ -162,12 +162,12 @@

     my $feed = XML::Atom::SimpleFeed->new(
         title   => '[' . $project->name . '] Smolder - ' . HostName,
-        link    => $self->url_base,
-        id      => $self->url_base,
+        link    => Smolder::Util::url_base(),
+        id      => Smolder::Util::url_base(),
         updated => $updated->strftime('%FT%TZ'),
     );
     foreach my $report (@reports) {
-        my $link = 'http://' . HostName .
'/app/developer_projects/smoke_report/' . $report->id;
+        my $link = Smolder::Util::url_base() .
'/app/developer_projects/smoke_report/' . $report->id;
         $feed->add_entry(
             title => '#'
               . $report->id . ' - '

Re: [smolder-devel] question about hostnames and ports in RSS feed

[Michael P. <mp...@pl...>]

Andrew Moore wrote:

> I recently installed smolder on a non-standard port (8000 instead of
> 80), and found that I had to make a few changes to
> lib/Smolder/Control/Public/Projects.pm to make the RSS feed work for
> me. I'm wondering if this is because of a configuration problem on my
> side or because I'm not running it on a standard port.

It's probably a problem with Smolder. I don't run on a non standard port 
so I don't test those things as thoroughly as I should.

> Anyway, here's the diff. It's small enough that you can probably copy
> it by eye it into the repository, but let me know if you'd rather I
> diff this against svn or something else.

Thanks! Applied to svn and it should appear in the next version (1.24).

-- 
Michael Peters
Plus Three, LP