From: Phil W. <ph...@su...> - 2003-04-16 21:55:39
|
Hi Guido, Bruce, > > As far as I understand knowndrives.h specialpurpose() would be used to > > set a flag that byteswapping is needed not to do the actual > > byteswapping, correct? So what I meant is just: should we try to move > > to bitfields for storing drive specific flags, so we can reuse them in > > the drives database? Sorry for being confusing... > > OK. I understand. > > > > I'm not opposed to this, though at the moment it seems to me a feature > > > that will be used very rarely, and is not any simpler in the real > > > implementation than what we currently use. Since Phil is writing the > > > code, he should decide if he wants to keep the existing structure or do > > > something along the lines that you have suggested. > > > O.k. Just let me know when I should add some code. > > Phil, this sounds to me like an offer to help... but you should decide if > you want to go with the existing structure or if you'd rather use > bitfields as Guido suggests. If you are having trouble deciding, I'd go > with the one that leads to the simplest implementation. I'm on the fence on this one as well, I'm afraid Guido. If you have strong feelings about it then I'm happy that you or I make the changes, but I've a slight preference towards leaving things as they are, to be reconsidered if we find that we've added lots of drives that use special purpose functions just to set elements of the con structure. Though as Bruce said, it might be rare for drives to need to do that. Phil |