From: Steve L. (JIRA) <ji...@sm...> - 2009-09-14 10:50:34
|
[ http://jira.smartfrog.org/jira/browse/SFOS-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11813#action_11813 ] Steve Loughran commented on SFOS-1275: -------------------------------------- The tighter signature would throw SmartFrogException, RemoteException, NotBoundException: the last one is odd; its from RMI, but it is not an IO or RMIException instance. Annoying. > DefaultRootLocatorImpl.getRootProcessCompound() could have its exception list tightened > --------------------------------------------------------------------------------------- > > Key: SFOS-1275 > URL: http://jira.smartfrog.org/jira/browse/SFOS-1275 > Project: SmartFrog > Issue Type: Improvement > Components: .sfCore > Affects Versions: 3.17.014 > Reporter: Steve Loughran > Assignee: Julio Guijarro > > The signature of getRootProcessCompound is > public ProcessCompound getRootProcessCompound(InetAddress hostAddress, > int portNum) throws Exception { > This makes it a noisy method for others to use. It should be able to get away with just IO and SmartFrog exceptions > Proposed: create a slightly differently named method with the tighter signature, the existing method delegates all the work to this method, so remains unchanged. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.smartfrog.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |