Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#18 0609a: need a one-click Never Display

closed
None
5
2004-06-14
2004-06-09
Jamie McCarthy
No

We need a single button that will reset all selected topics to weight
0. The button should be called "Never Display."

(Rob also wants us to store the previous weights in story_param,
and provide a second button called "Un-Never Display" that
retrieves those old weights and restores them. But first things
first, we definitely need the Never Display button.)

Discussion

  • Chris Nandor
    Chris Nandor
    2004-06-09

    Logged In: YES
    user_id=3660

    OK, added. Also added a feature to revert weights to their default values
    (NOT their previous values, but their defaults, as saved in the topic tree).

     
  • Chris Nandor
    Chris Nandor
    2004-06-09

    • assigned_to: pudge --> jamiemccarthy
     
  • Jamie McCarthy
    Jamie McCarthy
    2004-06-11

    • status: open --> closed
     
  • Jamie McCarthy
    Jamie McCarthy
    2004-06-11

    Logged In: YES
    user_id=3889

    OK, except topics have no "default" weights in the topic tree so I am not
    sure what you did with Revert Weights. So I'm calling that not finished --
    see https://sourceforge.net/tracker/index.php?
    func=detail&aid=971284&group_id=4421&atid=634206

    But the Never Display works (yay).

     
  • Chris Nandor
    Chris Nandor
    2004-06-11

    • status: closed --> open
     
  • Chris Nandor
    Chris Nandor
    2004-06-11

    Logged In: YES
    user_id=3660

    Well, the functionality in this report is done. All that's needed is to get
    the actual weights into the tree, right now they are all "1". But this
    functionality works regardless of what that weight is. Right now, it
    assumes "1" for all, but when you preview, it remembers that weight
    instead.

    Try this, in PopupTree.pm:

    @{$topics{$tid}}{qw(value label height width image)} = (
    $tid, @{$top}{qw(textname height width image)}
    );

    Add "weight" to both (assmuming that's the correct key name from the
    tree ref). Then in the template:

    [% slashtopics.${leaf.value}.parent.${leaf.parent.0.value} || 1 %]

    Becomes:

    [% slashtopics.${leaf.value}.weight || 1 %]

     
  • Chris Nandor
    Chris Nandor
    2004-06-13

    Logged In: YES
    user_id=3660

    Ignore this whole last comment, and go to new bug report (#971284).

     
  • Jamie McCarthy
    Jamie McCarthy
    2004-06-14

    • status: open --> closed