#71 Patches for Slash/Win32

closed-accepted
nobody
None
5
2002-09-09
2002-01-07
Kevin Tam
No

Here are some minor patches to get things to work with
Win32 NT systems

Discussion

  • Kevin Tam
    Kevin Tam
    2002-01-07

    Diffs of various files

     
    Attachments
  • Andrea M.
    Andrea M.
    2002-01-07

    Logged In: YES
    user_id=121571

    If I install this, run a site and then switch to linux will
    the database content be portable?

     
  • Kevin Tam
    Kevin Tam
    2002-01-08

    Logged In: YES
    user_id=229427

    Re: If I install this, run a site and then switch to linux
    will the database content be portable?

    That's a definite yes. In fact, the whole point of moving
    to Windows was so that I could import my Linux slash
    database and do some editting while in Windows. The two are
    completely interoperable. Furthermore, the attached code
    patches shouldn't change (or break) linux operations

     
  • Kevin Tam
    Kevin Tam
    2002-01-08

    Logged In: YES
    user_id=229427

    Re: If I install this, run a site and then switch to linux
    will the database content be portable?

    That's a definite yes. In fact, the whole point of moving
    to Windows was so that I could import my Linux slash
    database and do some editting while in Windows. The two are
    completely interoperable. Furthermore, the attached code
    patches shouldn't change (or break) linux operations

     
  • Kevin Tam
    Kevin Tam
    2002-01-11

    Diffs to allow working with win32

     
    Attachments
  • Kevin Tam
    Kevin Tam
    2002-01-11

    Logged In: YES
    user_id=229427

    Put the wrong diff for install-slashsite originally.
    Attached is a correct version

     
  • Chris Nandor
    Chris Nandor
    2002-09-09

    Logged In: YES
    user_id=3660

    Thanks for the patch. Some notes, to maximize portability:

    * I don't use $^O =~ /Win32/ but $^O eq 'MSWin32'; it's more
    specific and reliable for the future.
    * I didn't do unless $^O eq 'MSWin32' for alarm(), I used if
    $Config{d_alarm}.
    * Similarly for install-slashsite's uses of getgrent,
    getpwent, and symlink, I use Config.
    * Instead of calling perl -w $program for Win32, I just
    called $^X -w $program for all platforms.
    * For `hostname`, I made it run only under Linux. BSD,
    Solaris, Windows and more all have a problem with it, so
    screw it. :-)
    * A such, there was no need for Windows-specific code. :-)
    * The comment added to Slash::Utility::System has no comment
    and no version, so I don't know what it applies to.

    Thanks again.

     
  • Chris Nandor
    Chris Nandor
    2002-09-09

    • status: open --> closed-accepted