#70 Content Filter Regex Flag Heisenbug

closed-accepted
Rob Malda
5
2002-01-04
2002-01-03
chromatic
No

The filterOk() method id Slash::Utility::Access has a
questionable Perl construct that can lead to
hard-to-trace bugs in certain areas. Declaring a
lexical variable with a following if construct tends to
reuse the existing allocated memory when the boolean is
false. This means that the values of previous filters
can bleed through.

Predeclaring the variables or using the ternary
conditional operator fixes this. I've opted for the
second.

Discussion

  • chromatic
    chromatic
    2002-01-03

    Short patch to Slash::Utility::Access

     
    Attachments
  • Chris Nandor
    Chris Nandor
    2002-01-04

    • assigned_to: nobody --> cmdrtaco
    • status: open --> open-accepted
     
  • Chris Nandor
    Chris Nandor
    2002-01-04

    Logged In: YES
    user_id=3660

    Yep, thanks.

     
  • Rob Malda
    Rob Malda
    2002-01-04

    • status: open-accepted --> closed-accepted