Themes should never have a plugins directory under them. Ideally, if a theme and a plugin are supposed to go together, then the installer should force the issue. I don't think themes and plugins were ever intended to be bundled together like that.

Later design decisions could have completely trumped my stale recollection of things, however.

- Cliff

On Wed, Feb 9, 2011 at 5:07 PM, Marc G. Fournier <scrappy@hub.org> wrote:

Okay, am trying to do my first run at an install of slashtng, based on the
git repo that shane setup ... for the most part, things are going
smoothly, but on install, I'm hitting:

# Now all the themes
cp -r themes/* /usr/local/www/d_admin/ap13.slashtng.org/slash/themes
# Ensure we use the proper Perl interpreter and prefix in all scripts that
# we install. Note the use of Perl as opposed to dirname(1) and
basename(1)
# which may or may not exist on any given system.
(replacewith=`perl -MConfig -e 'print quotemeta($Config{startperl})' | sed
's/@/\\@/g'`;  binfiles=`find bin -name CVS -prune -o -name .git -prune -o
-name [a-zA-Z]\* -type f -print`;  sbinfiles=`find sbin -name CVS -prune
-o -name .git -prune -o -name [a-zA-Z]\* -type f -print`;
themefiles=`find themes -name CVS -prune -o -name .git -prune -o -name
[a-zA-z]\*.pl -print`;  pluginfiles=`find plugins themes/*/plugins -name
CVS -prune -o -name .git -prune -o -name [a-zA-Z]\*.pl -print`;
tagboxfiles=`find tagboxes themes/*/tagboxes -name CVS -prune -o -name
.git -prune -o -name [a-zA-Z]\*.pl -print`;  if [ "$replacewith" !=
"\#\!\/usr\/bin\/perl" ]; then  replace=1;  replacestr='(using perl)';
else  replace=0;  fi;  for f in $binfiles $sbinfiles $themefiles
$pluginfiles $tagboxfiles; do
n=/usr/local/www/d_admin/ap13.slashtng.org/slash/$f;  install -d
/usr/local/www/d_admin/ap13.slashtng.org/slash/$d;  if [ $replace ]; then
cat $f |  sed -e "1s/\#\!\/usr\/bin\/perl/$replacewith/" > $n.tmp;
install -m 0755 $n.tmp $n;  rm -f $n.tmp;  else  install $f $n;  fi;
done)
find: themes/*/plugins: No such file or directory
*** Error code 1

Stop in /usr/local/www/d_admin/ap13.slashtng.org/slash-git.


Now, there is a plugins directory, and a themes directory ... but there
are no plugins directories *under* themes ...

to get around, it appears the following patch needs to be applied:

# diff Makefile.orig Makefile
47,48c47,48
< PLUGINFILES = `find plugins themes/*/plugins -name CVS -prune -o -name
.git -prune -o -name [a-zA-Z]\*.pl -print`
< TAGBOXFILES = `find tagboxes themes/*/tagboxes -name CVS -prune -o -name
.git -prune -o -name [a-zA-Z]\*.pl -print`
---
> PLUGINFILES = `find plugins -name CVS -prune -o -name .git -prune -o
-name [a-zA-Z]\*.pl -print`
> TAGBOXFILES = `find tagboxes -name CVS -prune -o -name .git -prune -o
-name [a-zA-Z]\*.pl -print`

Does anyone know if there is ever a case where a theme *will* have a
plugins (or tagboxes) directory under them?

At this time, none of the three themes appears to have such ...



----
Marc G. Fournier                        Hub.Org Hosting Solutions S.A.
scrappy@hub.org                                     http://www.hub.org

Yahoo:yscrappy    Skype: hub.org    ICQ:7615664    MSN:scrappy@hub.org

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Slashcode-general mailing list
Slashcode-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/slashcode-general