Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#143 improve createStory/deleteSubmission

open
nobody
None
1
2002-11-21
2002-04-07
Jamie McCarthy
No

(This is actually more "submissions" and less
"stories")

createStory() and deleteSubmission() are both
ugly and need to be improved. Among other
related things in this same area:

* createSubmission() needs to gracefully handle
two attempted submission creations in the same
second (this is important for plugins/Newsvac
among other things) -- best way to do this is
rework the table to have a numeric autoincrement
primary key, the changes required for this are
significant and pervasive but not impossible

* createStory() needs to gracefully handle two
attempted story creations in the same second
(currently its key is wholly based on timestamp)
(giving it a numeric primary key would be nice, but
that's not gonna happen anytime real soon)

* quickie creation sucks, we need to rethink how
those submissions are made into a story. deleting
them all before the story is saved is probably *not*
a good idea. the first time Rob's browser crashes
before he clicks Save, he's gonna be pissed

* deleteSubmission() and probably other
submission-related methods have creaky old code
that relies excessively on $form -- rewrite

Discussion

  • Logged In: NO

    "the first time Rob's browser crashes before he clicks
    Save, he's gonna be pissed"

    Maybe if you were using Internet Explorer 6, you wouldn't
    have to worry about the browser crashing?

     
  • Logged In: NO

    So THAT'S why we don't get Quickies anymore! :-)

     
  • Jamie McCarthy
    Jamie McCarthy
    2002-06-19

    • priority: 6 --> 2
     
  • Jamie McCarthy
    Jamie McCarthy
    2002-06-19

    Logged In: YES
    user_id=3889

    createSubmission() now has a numeric primary key (thanks
    krow or whoever).

    createStory() now gracefully handles multiple creations in
    the same second.

    The quickies issue affects us with low frequency, and the
    deleteSubmission() issue is a "wouldn't it be nice" deal, so
    I'm downgrading this bug's priority.

     
  • Jamie McCarthy
    Jamie McCarthy
    2002-11-21

    Logged In: YES
    user_id=3889

    createSubmission() and createStory() have been improved in
    the ways described, months ago.

    quickies isn't a high priority since it's never caused
    problems and is infrequently used.

    And as for passing more arguments to deleteSubmission()
    instead of using the global $form, eh, this would be more
    MySQL.pm-like but it works fine, it's secure, so it isn't a
    high priority either.

     
  • Jamie McCarthy
    Jamie McCarthy
    2002-11-21

    • labels: 101849 -->
    • milestone: 169310 -->
    • priority: 2 --> 1
    • assigned_to: jamiemccarthy --> nobody