Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2556 Comment pagination showing up when viewing single comment

Slashdot
closed-fixed
Rob Malda
Comments (601)
9
2003-07-14
2003-07-03
Quietust
No

If I view a discussion that would normally be split up into
multiple pages at my current threshold, I get the "(1)
|2|3..." links even if I'm only viewing a single comment.

1. Set comment limit to 100
2. Open a discussion that contains more than 100
comments.
3. Switch to a lower threshold (if necessary) to force it
to spill to multiple pages.
4. View a single comment within the discussion.
5. Set the threshold to the same value as in #3.

Discussion

  • Rob Malda
    Rob Malda
    2003-07-04

    • priority: 5 --> 9
    • assigned_to: nobody --> cowboyneal
     
  • Jonathan Pater
    Jonathan Pater
    2003-07-07

    Logged In: YES
    user_id=24936

    this was a bug in my last patch that used $comments-
    >{0}{totals} for finding the total comments, even if viewing a
    single comment. I've updated it to now use $comments-
    >{$cid}{totalvisiblekids} which is much more correct, and will
    be zero for single comment viewing pages.

     
  • Jonathan Pater
    Jonathan Pater
    2003-07-07

    • assigned_to: cowboyneal --> cmdrtaco
    • status: open --> open-fixed
     
  • Rob Malda
    Rob Malda
    2003-07-08

    • status: open-fixed --> closed-fixed
     
  • Quietust
    Quietust
    2003-07-08

    • status: closed-fixed --> open-fixed
     
  • Quietust
    Quietust
    2003-07-08

    Logged In: YES
    user_id=56060

    If I change my threshold while viewing a single comment, it
    adds a "pid=NNNNNN" parameter (where NNNNNN is always
    identical to the "cid" parameter) to the URL and it starts
    showing the bogus pagination links again.

     
  • Quietust
    Quietust
    2003-07-10

    Logged In: YES
    user_id=56060

    ...and suddenly, it's all working the way it should. :)

     
  • Rob Malda
    Rob Malda
    2003-07-14

    • status: open-fixed --> closed-fixed