#16 Improve const-correctness

open
nobody
None
5
2008-02-15
2007-03-13
Markus Elfring
No

Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const_correctness" to more places in your sources?
I suggest to add the key word "const" to the type specifiers for parameters like the following.
- http://sipp.svn.sourceforge.net/viewvc/sipp/sipp/trunk/auth.c?revision=154&view=markup
base64, hexa (global "variables")
user, password, method, uri, msgbody, auth, algo (function "createAuthHeaderMD5")
http://cvs.sourceforge.net/viewcvs.py/sox/sox/src/FFT.h?rev=1.1&view=markup

- http://sipp.svn.sourceforge.net/viewvc/sipp/sipp/trunk/rijndael.c?revision=27&view=markup
ft_tab, fl_tab (global "variables")

Discussion

  • Logged In: YES
    user_id=999021
    Originator: NO

    Hi Markus, as many other Open Source projects, SIPp is contribution driven. I will be very happy to receive a patch from you that implements this and check it in after review. Thanks a lot.

     
  • Logged In: YES
    user_id=1475960
    Originator: NO

    No patch received.

     
    • status: open --> closed
     
  • Markus Elfring
    Markus Elfring
    2008-02-15

    • summary: Improve "const correctness" --> Improve const-correctness
    • status: closed --> open
     
  • Markus Elfring
    Markus Elfring
    2008-02-15

    Logged In: YES
    user_id=572001
    Originator: YES

    Does the appended file contain acceptable changes?
    File Added: 1680134.diff.bz2

     
  • Markus Elfring
    Markus Elfring
    2008-02-17

    update suggestion

     
    Attachments
  • Markus Elfring
    Markus Elfring
    2008-02-17

    Logged In: YES
    user_id=572001
    Originator: YES

    Would you like to provide a clear distinction between input and output parameters as an easy documentation aid?
    File Added: 1680134.diff.bz2