#216 SIPE Stops working on Mavericks

1.17.x
closed-invalid
nobody
None
Adium
5
2014-10-27
2013-10-16
Jon Anhold
No

Upgraded to Mavericks, now get an "Error: Read error" when trying to connect to OCS.

Related

Bugs: #235
Release Notes: 2014/01/pidgin-sipe-release-1180

Discussion

<< < 1 2 3 (Page 3 of 3)
  • appelk
    appelk
    2013-11-11

    It looks like your change did not cause the crashing as commenting out your lines has the same results. I tried on versions 1.7hg and 1.6hg with the same result.

    I can't even get 1.5.8 to launch on OS X 10.9, so I can't report on if that is working.

     
  • JPR
    JPR
    2013-11-11

    I'm seeing the same behavior, but I'm just checking out the released code (1.5.8), compiling, and running Adium without any changes. There's a log message too:

    *** WARNING: -[NSImage compositeToPoint:fromRect:operation:fraction:] is deprecated in MacOSX 10.8 and later. Please use -[NSImage drawAtPoint:fromRect:operation:fraction:] instead.

     
  • Chris LUff
    Chris LUff
    2013-11-12

    I have compiled against 1.5.9b2. It connects fine but it will stop responding when initiating a message. I am struggling to get 1.5.8 to even compile right now.

    I got pretty excited for a few minutes. Stefan, the effort you have made is appreciated!

     
    • Stefan Becker
      Stefan Becker
      2013-11-12

      The only compilation problem I faced with Adium 1.5.8 on OS X 10.9 was a missing header file "DNSService...something....h". I googled for it and copied it from opensource.darwin.org into the Adium source tree and changed in the editor the <> to "" so it picked up the header from the current directory.

       
      • Chris LUff
        Chris LUff
        2013-11-12

        LOL, I had literally just figured that was the problem and copied it from http://www.opensource.apple.com/source/mDNSResponder/mDNSResponder-320.10/mDNSMacOSX/DNSServiceDiscovery.h?txt

        Compiled now; lets see how we get on.

        Thanks!
        C

         
        • Chris LUff
          Chris LUff
          2013-11-12

          Yep, now working fine on 10.9 with Adium 1.5.8 and SIPE SIPE 1.17.0 with your suggested code.

          Thanks!

           
          • JPR
            JPR
            2013-11-12

            I'm curious, do you use any chat protocols in Adium other than Communicator? Whenever I've compiled with the 10.9 SDK, nothing works unless I apply Stefan's patch, and even then only Communicator works. I could get on Google Chat, Bonjour and Facebook when I compile with 10.8 SDK, but then it doesn't seem possible to include the patch.

             
            • Stefan Becker
              Stefan Becker
              2013-11-12

              kSSLSessionOptionSendOneByteRecord has been added in 10.9 SDK. I guess the patch could be changed to check for the OS version and copy the value from 10.9.

               
              • JPR
                JPR
                2013-11-12

                I'm not proud of what I did here, but here's how I got a full-functioning Adium on 10.9.

                Inject your patch, but substitute 4 for kSSLSessionOptionSendOneByteRecord. I'm not proud of this, but it lets me compile against the 10.8 SDK - 10.9 breaks Gchat, Bonjour and possibly others.

                Compile in Xcode using the 10.8 SDK.

                Voila. I can run Gchat, Facebook, Bonjour, and SIPE simultaneously.

                Thanks for your work and communication on this one Stefan.

                 
                • Stefan Becker
                  Stefan Becker
                  2013-11-12

                  Just to be clear: you compiled on 10.9 but against the 10.8 SDK? It is certainly strange, but maybe Adium 1.5.8 depends on some backward compatibility that has been removed in 10.9 SDK.

                  Hard-coding the value is what you need to do on 10.8, so your approach is correct. Personally I would refine it though like this (sorry, pseudo code, no Mac here right now):

                  #if _MAC_OS_X_SDK < 10_9
                  #define kSSLSessionOptionSendOneByteRecord 4 /* appears in 10.9
                  #endif
                  
                  if (!strcmp(plugin,"prpl-sipe") &&
                      runtime_check_is_OS_X_version_min(10, 9))  {
                    ... disable SSL BEAST mitigation ...
                  }
                  

                  With this it would compile on any Mac OS X version and only disable SSL BEAST mitigation on 10.9 and up.

                   
                  • JPR
                    JPR
                    2013-11-12

                    ...compiled on 10.9 but against the 10.8 SDK?

                    Correct. 10.9 is what my Xcode env is set up in, but I don't know any reason it wouldn't work compiling on 10.8. The 10.9 SDK breaks some other protocols for reasons I haven't really explored yet.

                    Good thoughts on the version checking and define - thanks. I did consider #ifndef as a possible strategy but didn't take the time to connect all the dots.

                     
  • Stefan Becker
    Stefan Becker
    2013-11-12

    OK, with all the effort our Open Source project has now put into this, I have to ask this:

    Would any Adium/SIPE user, or their employers, who benefit from all this work-for-free consider supporting the SIPE project by sponsoring some Mac HW with 10.9? The benefits would be:

    • Adium plugin released at the same time as the source and the Windows binaries
    • account setting changes would be reflected in Adium UI code updates
    • possibility to work on Adium SIPE bugs
    • possibility to improve Adium SIPE, e.g. replace NSS with Security Framework thus dropping the dependency on NSS.
     
    • Ken Botwinick
      Ken Botwinick
      2013-11-13

      When I think of donating, the number $35 pops into my mind. It's not going to get you any mac hardware, but where can I send it?

       
    • R.Coulter
      R.Coulter
      2013-11-13

      If you don't mind me asking, what does it take to test/debug/build/release the Adium plugin, and how do you currently achieve that?

       
      • Michael Lamb
        Michael Lamb
        2013-11-13

        Currently I'm doing it. However, my day job keeps me pretty busy so I'm not as quick to fix things as Stefan is.

        There is a README that outlines how to build the plugin... however it may not be as clear as I had hoped. I'm working on a re-write of the build process, but it's subject to the same restrictions mentioned.

        If you have specific questions about the current README, you can ask me directly and I can walk you through it.

         
      • Stefan Becker
        Stefan Becker
        2013-11-13

        Currently I don't, Michael does (who just answered the same question).

         
  • Ken Botwinick
    Ken Botwinick
    2013-11-13

    Oh, and couldn't you just use a VMWare of the Mac OS? As long as you paid for a legal copy of the OS? Which of course is now free...

     
    • Stefan Becker
      Stefan Becker
      2013-11-13

      AFAIK the only legal way to run Mac OS X on Apple HW. And there's a lot of components you need to touch

       
  • Stefan Becker
    Stefan Becker
    2013-11-16

    I've updated the patch with a SDK version detection and added it to the git repository with a README.

     
  • Stefan Becker
    Stefan Becker
    2013-11-30

    Michael came up with an improved version of the patch and has submitted it to the Adium project for integration. Once this is integrated SIPEAdiumPlugin can be updated to have a checkmark in the account settings UI to disable SSL BEAST mitigation.

     
  • Stefan Becker
    Stefan Becker
    2013-12-03

    UI option to disable BEAST mitigation implemented in git commit fe25e76. Please note that the patch for Adium has been updated too!

     
  • Hi Stefan, I'm a bit confused - will this now be in SIPE 1.17.x ? (1.17.3???) If so should the status be updated from 'closed-invalid' to 'closed-fixed' ???

    (Right now I have patched this myself on the 1.17.0 base per the directions on this thread and have my own binary but Adium 1.7hg doesn't seem to be stable with it so I'd rather be on the 'official' patch rather than my cobbled version)

    Thanks,
    Mike

     
  • Stefan Becker
    Stefan Becker
    2013-12-05

    It has never been a bug in SIPE, that's why it will stay on "closed-invalid". The UI option is only there to enable a workaround in the Mac OS X SSL code.

    There have been major changes to the SIPEAdiumPlugin code & project structure, which makes it impossible to backport the UI feature to 1.17.x. Also modifying the UI is for my taste too big a change for a bug fix release.

    The other reason why this doesn't get released in 1.17.x is that the required Adium changes will only be available in Adium 1.5.10.

     
<< < 1 2 3 (Page 3 of 3)