Re: [sigrok-devel] link-mso19 drivers

[Lior E. <lel...@ya...>]

Sorry, I been just hitting reply. 
I will try to keep the tabs clean. 
Lior.


________________________________
 From: Uwe Hermann <uw...@he...>
To: Lior Elazary <lel...@ya...> 
Sent: Tuesday, January 8, 2013 7:04 PM
Subject: Re: [sigrok-devel] link-mso19 drivers
 
Hi,

On Tue, Jan 08, 2013 at 08:41:37AM -0800, Lior Elazary wrote:
> I have a new patch with all the warning fixed and added the analog probe. 

Thanks, will have a look at that tomorrow.

Btw, I think you're only replying to me, not to the mailing list. Is
that intentional? Usually the public discussions should all go to the
mailing list. No need to resend this mail, but please keep further mails
on the list unless there's some reason not to.


> I also added the following to the end of the link-mso19 files to insure that the tab spaces are what you guys like. 
> 
> /* So things look consistent in everyone's emacs/vi ... */
> /* Local Variables: */
> /* mode:c */
> /* comment-column:0 */
> /* indent-tabs-mode:nil */
> /* tab-width:2 */
> /* End: */
> /* vim: set noexpandtab tabstop=2 smarttab shiftwidth=2: */
> 
> Please let me know if that is ok, before I continue on. 

Nah, please don't add such stuff to files, it's just useless clutter.

I just checked
0001-Added-local-file-variables-to-automatically-configur.patch, please
drop that. The other two look OK from a quick glance, but I'll have more
time tomorrow.

Here's what I used for auto-fixing btw, in case you're interested. You
should NOT simply run this on the code randomly though, it only gets 80%
of the stuff right, and requires manual fixups too, but just to get an idea.

indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs foo.c


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org