#25 Nor fully fixed: Records with "mfrom" are not detected

v1.0.0
open
nobody
5
2010-05-29
2006-12-17
Ache
No

sid-milter not detect construction now proposed in Sender-ID specs everywhere (look at http://www.ietf.org/rfc/rfc4406.txt f.e.) because
it not understand its "mfrom" part. The patch attached with the fix. (However only "pra" is really handled as before, no "mfrom" actions)

Discussion

  • Ache
    Ache
    2006-12-17

    "mfrom" patch

     
    Attachments
    000
    • assigned_to: nobody --> sm-msk
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    An equivalent patch will appear in v1.0.0 (release pending).

     
    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=1048957
    Originator: NO

    Fixed in 1.0.0, now released.

     
  • Ache
    Ache
    2008-06-09

    Logged In: YES
    user_id=295536
    Originator: YES

    There is mistake in the v1.0.0 fix. According to RFC4406 "pra" and "mfrom" may come in _any_ order, while the code under !defined(_FFR_NH_MFROM) check the only _one_ of them, "pra" first (see below). The code under defined(_FFR_NH_MFROM) does it right, so just simple unifdef FFR_NH_MFROM at this place:

    sid-filter.c:
    case SM_SCOPE_PRA:
    #ifdef _FFR_NH_MFROM
    if ((strncasecmp(mreplies[rcount],
    "spf2.0/pra",
    10) == 0) ||
    (strncasecmp(mreplies[rcount],
    "spf2.0/mfrom,pra",
    16) == 0))
    #else /* _FFR_NH_MFROM */
    if (strncasecmp(mreplies[rcount],
    "spf2.0/pra", 10) == 0)
    #endif /* _FFR_NH_MFROM */

     
  • Ache
    Ache
    2008-06-09

    • milestone: 624035 --> v1.0.0
    • summary: Records with "mfrom" are not detected --> Nor fully fixed: Records with "mfrom" are not detected
    • status: closed-fixed --> open
     
    • assigned_to: sm-msk --> nobody