Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1 Remove SickConfig.hh from Header Includes

closed-fixed
None
5
2008-03-24
2008-03-19
Tully Foote
No

SickConfig.hh should be included by the implementations but not the header files. They are necessary when compiling the library but are not necessary for linking against the library.

The problem with including them in the header files is that the #defines are global and can conflict with other defines. The ones I had trouble with in particular were PACKAGE and PACKAGE_NAME for they conflicted with another misconfigured autotools package.

My work around was to delete the contents of SickConfig.hh from the installed version. The SickConfig.hh file should probably not even be installed.

Discussion

  • Jason Derenick
    Jason Derenick
    2008-03-20

    • assigned_to: nobody --> derenick
     
  • Jason Derenick
    Jason Derenick
    2008-03-24

    • status: open --> open-fixed
     
  • Jason Derenick
    Jason Derenick
    2008-03-24

    • status: open-fixed --> closed-fixed