Hi :)

On Tue, Nov 30, 2010 at 12:26 AM, Hartmut Goebel <h.goebel@goebel-consult.de> wrote:
Hi,
  1. Is it really necessary to retry execution via the shell (shell_launch=True)? In my test, shell-scripts have been executed fine even with Popen(..., shell=False)
If I remember right, the | and co things were not good. I'll look at the tests to see if it's so true (if I'm wrong, it's better, far less code :) ). But there are commands that raised an Exec format error like centreon perfdata launch, that are a shell script ... without #!/bin/sh ;(
 
  1. Is this statement "We allow direct launch only for 2.7 and higher version because if a direct launch crash, under this the file handles are not released" referring to the bug fixed in Python revision 69620? (See <http://svn.python.org/view/python/tags/r271/Lib/subprocess.py?r1=67543&r2=69620>)
Seems this one yes. It's a problem when you got an exception on the Popen the file descriptors are not closed. So inthe code, we loop to the shell launch, and it run. But after 500 launch, we fill up the 1024 fd limit, and then all checks are bad with a Too much open files open.


Jean
 
-- 
Schönen Gruß - Regards
Hartmut Goebel
Dipl.-Informatiker (univ.), CISSP, CSSLP

Goebel Consult 
Spezialist für IT-Sicherheit in komplexen Umgebungen
http://www.goebel-consult.de

Monatliche Kolumne: http://www.cissp-gefluester.de/
Goebel Consult mit Mitglied bei http://www.7-it.de

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel