I would like to ask you to write more meaninfful commit messages.
Currently messages are like:
I'm wondering what these commits are doing any why. (The last one is
really bad: The commit is simply adding another easter-egg.) In the
git-world, it's common to use the first line as a summary and add
details behind. So you are nor restricted to a single line :-)
- Fix : get back tests like before.
- Fix : regression Fix #478
- Just restore a beginning of file to fit old numbers of line
and avoid repositionning all following lines. Yeah it is a quite
long commit log message :p
- Add : something very very very .... not important.
Good commit messages are important. They tell others why you did
changes you did, not just right here and now, but months or years
now when someone wonders why some seemingly illogical or
piece of code snuck into your source file. It is also an
aid to deciding which changes to back-port merge from the
development branch to the release-branch and which not.
Thus I ask you to write more meaningful commit messages. Shinken has
grown big now, so IMHO we should put some eye on development
For the PyInstaller project we commited us to the rules described in
These rules are based on eg. the FreeBSD Committer's Guide. There is
also a guide "How to write a good commit message".
I would really appreciate to see more meaningful commit messages in
| Hartmut Goebel | firstname.lastname@example.org |
| www.crazy-compilers.com | compilers which you thought are impossible |