Okay, so after fixing basicListItem as mentioned previously, I don't seen anything wrong with the format of the Semantic Drilldown. Except for the fact that the category list on the right pushes down the right-most column. Easy enough to fix, just put a <DIV> around the columns, I think.

On Mon, Jul 26, 2010 at 2:09 PM, Yaron Koren <yaron57@gmail.com> wrote:
Hi,

Well, I'd say the best approach to trying out (and hopefully debugging) the problem is to download and install Semantic Drilldown, which you can do from here:

http://www.mediawiki.org/wiki/Extension:Semantic_Drilldown

After that, if you go to the page Special:BrowseData, you should, I assume, be able to see the problem quickly.

-Yaron


On Mon, Jul 26, 2010 at 1:53 PM, John Arrowwood <John@irie-inc.com> wrote:
I have not. Give me a link, and I will look at what it generated, see if it is something simple.


On Mon, Jul 26, 2010 at 1:27 PM, Yaron Koren <yaron57@gmail.com> wrote:
HI,

Cool - breaking up code into more functions is almost always a good idea. I just tried this, though, and it caused Semantic Drilldown, which uses 'category' as its default display format, to display weird results in Special:BrowseData. Have you tried this code with Semantic Drilldown? It's probably the biggest single user of the 'category' format.

-Yaron


On Mon, Jul 26, 2010 at 12:05 PM, John Arrowwood <John@irie-inc.com> wrote:
Okay, I took a crack at it.

The original code was a bit monolithic. In order to be able to build a new algorithm that did things in a different order, I had to take pieces of the original code and break them off and call them. This allowed the column breaking code to be easier to see and follow, without being cluttered by the housekeeping code that generated the HTML, etc.

Test it out for yourselves, and see if you want to roll it into the main code base or not.

-- John



On Sun, Jul 11, 2010 at 7:50 PM, Yaron Koren <yaron57@gmail.com> wrote:
Hi John,

The category format was created by David Loomer and me, entirely with custom code (though I think we both looked at how the main MediaWiki code does it). In any case, if you want to take a crack at improving the code, that would definitely be welcome - you can just send a patch to the semediawiki-devel mailing list.

-Yaron

On Sun, Jul 11, 2010 at 10:00 AM, John Arrowwood <John@irie-inc.com> wrote:
I noticed that it seemed kinda weird how the columns were not always
balanced. Finally, I started counting, and realized that it's because it
does not take into account the section headers that it needs to insert.

A proper implementation should obey the following rules:

1. headers count, and should probably count as 2 items
2. don't split a section with less than 4 items in it
3. don't split a section after only 1 item, or with only 1 item left

I haven't looked into the code, are we implementing our own category column
splitting algorithm, or just leveraging the one built into MediaWiki?

--
John Arrowwood
John (at) Irie (dash) Inc (dot) com
John (at) Arrowwood Photography (dot) com
John (at) Hanlons Razor (dot) com
--
http://www.irie-inc.com/
http://arrowwood.blogspot.com/
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Semediawiki-user mailing list
Semediawiki-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-user



--
WikiWorks MediaWiki Consulting http://wikiworks.com



--
John Arrowwood
John (at) Irie (dash) Inc (dot) com
John (at) Arrowwood Photography (dot) com
John (at) Hanlons Razor (dot) com
--
http://www.irie-inc.com/
http://arrowwood.blogspot.com/



--
WikiWorks MediaWiki Consulting http://wikiworks.com



--
John Arrowwood
John (at) Irie (dash) Inc (dot) com
John (at) Arrowwood Photography (dot) com
John (at) Hanlons Razor (dot) com
--
http://www.irie-inc.com/
http://arrowwood.blogspot.com/



--
WikiWorks MediaWiki Consulting http://wikiworks.com



--
John Arrowwood
John (at) Irie (dash) Inc (dot) com
John (at) Arrowwood Photography (dot) com
John (at) Hanlons Razor (dot) com
--
http://www.irie-inc.com/
http://arrowwood.blogspot.com/