Hey,

Yes, you did need the coder right, which I have now given you. You can grant the right (when you have it) to someone else by going to http://www.mediawiki.org/wiki/Special:UserRights/UserName, where UserName is their user name on MediaWiki.org.

Cheers

--
Jeroen De Dauw
* http://blog.bn2vs.com
* http://wiki.bn2vs.com
Don't panic. Don't be evil. 50 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65!
--


On 20 July 2010 22:35, Denny Vrandecic <denny.vrandecic@kit.edu> wrote:
Hi Jeroen,

is there a quick description of how the code review works? I just checked your last commit,

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/69630

and wanted to accept it, but it seems I cannot do that. Maybe I am missing coder rights?

Cheers,
Denny

P.S.: my login is "Denny"


On Jul 20, 2010, at 7:06, Jeroen De Dauw wrote:

> Hey,
>
> As I mentioned in a discussion a while back, I'm willing to do code review for the semantic extensions. It'd be nice if someone could review my commits though, as I obviously can't do that myself. And obviously, the more people reviewing, the easier it gets :)
>
> For people not familiar with MediaWiki code review:
> It's done here: http://www.mediawiki.org/wiki/Special:Code/MediaWiki
> In order to change the review status of a commit you need to have the 'Coder' right. Everyone that has that right can give it to other users as well, so feel free to poke me if you need it.
>
> Cheers
>
> --
> Jeroen De Dauw
> * http://blog.bn2vs.com
> * http://wiki.bn2vs.com
> Don't panic. Don't be evil. 50 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65!
> --
>
>
> ---------- Forwarded message ----------
> From: Chad <innocentkiller@gmail.com>
> Date: 20 July 2010 15:20
> Subject: Re: [Wikitech-l] CodeReview auto-deferral regexes
> To: Wikimedia developers <wikitech-l@lists.wikimedia.org>
>
>
> On Tue, Jul 20, 2010 at 9:16 AM, Jeroen De Dauw <jeroendedauw@gmail.com> wrote:
> > Hey,
> >
> > About the semantic extensions:
> >
> > It would actually be nice if they did not get marked deferred at all, and be
> > reviewed by people that are familiar with them to some extend. I'm willing
> > to do that for all commits not made by myself. Assuming this would not
> > interfere to much with WMF code review of course :)
> >
> > Cheers
> >
>
> If someone's going to start doing code review, that's fine. They've
> just all been getting deferred because nobody's been reviewing
> them so far.
>
> -Chad
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first_______________________________________________
> Semediawiki-devel mailing list
> Semediawiki-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/semediawiki-devel