#192 Query result displays "...Clear..." link incorrectly

BASE
closed-duplicate
nobody
Interface (166)
5
2008-04-14
2008-03-19
kmarion
No

Description:

The query result displays link for "...Clear..." incorrectly in the section "Meta Criteria" and "Signature Classification". New option "htmlentities" added to class "SignatureClassificationCriteria" Function "Description" causes the link created for "...Clear..." without the HTML code tags and is translated to HTML safe characters.

Simple Example:
(Not actual BASE code, just simple example)
=========================
<A HREF="code.php?var=1">...Clear...</A>

is being translated to:

&lt;A HREF=&quot;code.php?var=1&gt;...Clear...&lt;/A&gt;

Suggested fix:

Remove "htmlentities" when creating the description from "$this->cs->GetClearCriteriaString"

Suggested Patch for BASE 1.3.9:

--- /tmp/base-1.3.9/includes/base_state_citems.inc.php 2007-11-20 19:58:48.000000000 -0600
+++ base_state_citems.inc.php 2008-03-19 13:13:15.000000000 -0500
@@ -510,7 +510,7 @@
else
$tmp = $tmp._SIGCLASS.' = '.
htmlentities(GetSigClassName($this->criteria, $this->db)).
- htmlentities($this->cs->GetClearCriteriaString($this->export_name)).'<BR>';
+ $this->cs->GetClearCriteriaString($this->export_name).'<BR>';
}
}

Discussion

  • kmarion
    kmarion
    2008-03-19

    Logged In: YES
    user_id=1799966
    Originator: YES

    Didn't mention earlier but found the problem in BASE 1.3.9. Thx.

     
  • Kevin Johnson
    Kevin Johnson
    2008-04-14

    Logged In: YES
    user_id=836228
    Originator: NO

    This has already been reported and fixed. But I appreciate the bug report.

    thanks,
    Kevin

     
  • Kevin Johnson
    Kevin Johnson
    2008-04-14

    • status: open --> closed-duplicate