From: SourceForge.net <no...@so...> - 2009-06-07 13:24:19
|
Patches item #2802510, was opened at 2009-06-07 15:24 Message generated for change (Tracker Item Submitted) made by rlar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2802510&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Robert Larice (rlar) Assigned to: Nobody/Anonymous (nobody) Summary: fix for bug #274088 Initial Comment: a support/reggression/tests file and a fix for bug [ 2740884 ] Incorrect assignment in array of structs https://sourceforge.net/tracker/?func=detail&group_id=599&atid=100599&aid=2740884 loopreversal was erronously applied, due to a missing check in function isConformingBody() for case PTR_OP ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2802510&group_id=599 |
From: SourceForge.net <no...@so...> - 2009-06-08 08:47:11
|
Patches item #2802510, was opened at 2009-06-07 15:24 Message generated for change (Comment added) made by rlar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2802510&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Robert Larice (rlar) Assigned to: Nobody/Anonymous (nobody) Summary: fix for bug #274088 Initial Comment: a support/reggression/tests file and a fix for bug [ 2740884 ] Incorrect assignment in array of structs https://sourceforge.net/tracker/?func=detail&group_id=599&atid=100599&aid=2740884 loopreversal was erronously applied, due to a missing check in function isConformingBody() for case PTR_OP ---------------------------------------------------------------------- >Comment By: Robert Larice (rlar) Date: 2009-06-08 10:47 Message: I'd like to withdraw my first patch, and thanks to Jan Waclawek, replace it with an extended version. in isConfirmingBody() the cases for INC_OP and DEC_OP have to be extended as well. furthermore i've added some asserts, and fixed an ugly typo, which by mere luck never made a difference. ---- apart from that I'd like to ask for reconsidering the whole business of this loop optimization. replacing isConfirmingBody with a mere !astHasSymbol(body, loopvarsymbol) && islocal(loopvarsymbol) would almost be the same thing, but much easier to understand. adding an optimization which tries to prove that the for-loops conditional expression is always TRUE for the first run, and then move the conditional to the end of the loop seems to me of higher value. (avoids double jumping for every iteration) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2802510&group_id=599 |
From: SourceForge.net <no...@so...> - 2009-07-18 14:00:52
|
Patches item #2802510, was opened at 2009-06-07 15:24 Message generated for change (Comment added) made by borutr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2802510&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Robert Larice (rlar) >Assigned to: Borut Ražem (borutr) Summary: fix for bug #274088 Initial Comment: a support/reggression/tests file and a fix for bug [ 2740884 ] Incorrect assignment in array of structs https://sourceforge.net/tracker/?func=detail&group_id=599&atid=100599&aid=2740884 loopreversal was erronously applied, due to a missing check in function isConformingBody() for case PTR_OP ---------------------------------------------------------------------- >Comment By: Borut Ražem (borutr) Date: 2009-07-18 16:00 Message: Patch applied in svn revision #5477. Borut ---------------------------------------------------------------------- Comment By: Robert Larice (rlar) Date: 2009-06-08 10:47 Message: I'd like to withdraw my first patch, and thanks to Jan Waclawek, replace it with an extended version. in isConfirmingBody() the cases for INC_OP and DEC_OP have to be extended as well. furthermore i've added some asserts, and fixed an ugly typo, which by mere luck never made a difference. ---- apart from that I'd like to ask for reconsidering the whole business of this loop optimization. replacing isConfirmingBody with a mere !astHasSymbol(body, loopvarsymbol) && islocal(loopvarsymbol) would almost be the same thing, but much easier to understand. adding an optimization which tries to prove that the for-loops conditional expression is always TRUE for the first run, and then move the conditional to the end of the loop seems to me of higher value. (avoids double jumping for every iteration) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2802510&group_id=599 |