[sdcc-devel] [ sdcc-Patches-3512989 ] [z80] Hardcoded "#0xNN"-like numbers elimination

[SourceForge.net <no...@so...>]

Patches item #3512989, was opened at 2012-03-29 15:01
Message generated for change (Comment added) made by spth
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=3512989&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: z80 port
Group: None
>Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Alexander Tsidaev (eltaron)
Assigned to: Philipp Klaus Krause (spth)
Summary: [z80] Hardcoded "#0xNN"-like numbers elimination

Initial Comment:
There were few hardcoded numbers in "#0xNN" notation in the gen.c
Assemblers other than asxxxx consider them as errors.

Solution: replaced using !immedbyte/!immedword.

----------------------------------------------------------------------

>Comment By: Philipp Klaus Krause (spth)
Date: 2012-06-15 10:44

Message:
Keeping it open for the other #-prefixed stuff.


----------------------------------------------------------------------

Comment By: Philipp Klaus Krause (spth)
Date: 2012-06-15 10:44

Message:
Implemented for all "#0x" in revision #7917.

Philipp


----------------------------------------------------------------------

Comment By: Alexander Tsidaev (eltaron)
Date: 2012-03-29 15:25

Message:
But I have not idea what to do with commands that can use negative numbers
like
int d = (stack < 127 ? -stack : -127);
emit2 ("add sp, #%d", d);

both !immedbyte and !immedword are replaced with 32-bit long number when
parameter is negative:
emit2("add sp, !immedbyte", -15) give us "add sp, #0xFFFFFFF1"
Is this a bug?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=3512989&group_id=599